[GRASS5] various v.digit bug reports

[cheg01 at attbi.com]

Several new bug reports on v.digit came up a few days ago:

***************************************************************
#1676: Subject: Debug menu in v.digit

Platform: GNU/Linux/i386
grass obtained from: Trento Italy site
grass binary for platform: Compiled from Sources
GRASS Version: 5.0.1

The 'n - Display node info' option of the Debug menu in v.digit seems
inactive.
Aldo Clerici

***************************************************************
This is true, the d_node_info code in lines 228-238 of  debug.c does
nothing. Should probably drop the "n - Display node info" menu item from
the Debug menu.

***************************************************************
#1674: Subject: Toolbox menu in v.digit

Platform: GNU/Linux/i386
grass obtained from: Trento Italy site
grass binary for platform: Compiled from Sources
GRASS Version: 5.0.1

In the 'n - Display Node lines' option in the Toolbox menu of v.digit, the
functions of the middle (Next line) and right (Quit) buttons are inverted.
Aldo Clerici

***************************************************************
It seems to be related to the following code:

In local_proto.h:

ifndef ANOTHER_BUTTON
# define MIDDLEB 2
# define RIGHTB 3
#else
# define MIDDLEB 3
# define RIGHTB 2
#endif

*************************

In mouse_yn.c

#ifdef ANOTHER_BUTTON
 Write_base(14, "       Middle: Quit") ;
 Write_base(15, "       Right:  Next line") ;
#else
 Write_base(14, "       Middle: Next line") ;
 Write_base(15, "       Right:  Quit") ;
#endif


*************************
In node_lines.c
Lines 59-77
 next_line = map->Node[node_num].n_lines - 1;
 Next = 3;
 prev_line = 0;
 first = 1;
 do {
     prev_line = next_line;
     switch (Next) {
  case 1:  /* prev */
      next_line = (next_line == 0 ?
    map->Node[node_num].n_lines -1 : next_line-1);
      break;
  case 2:  /* end */
      /* shouldn't get here */
      break;
  case 3:  /* next */
      next_line = (next_line == map->Node[node_num].n_lines -1 ?
        0 : next_line+1);
      break;
     }

****************************
and Lines 106-107

 } while (2 != (Next = mouse_next_prev ("Select Next line:")));
 display_line(map->Line[line_num].type, &Gpoints, line_num, map);
    }
****************************
So if ANOTHER_BUTTON is defined:
right button=2, middle button=3
on the menu, middle button =quit, right button=next line
middle button increments and shows next line
right button exits loop

So if ANOTHER_BUTTON is not defined:
right button=3, middle button=2
on the menu, right button =quit, middle button=next line
right button increments and shows next line
middle button exits loop


I think the solution is to swap the contents of case 2 and 3 in the first
loop, change "Next=3" to "Next=2" at line 58 and change "2 !=" to "3 !=" at
line 106 of node_lines.c.

***************************************************************
#1670: Subject: Color menu in v.digit

Platform: GNU/Linux/i386
grass obtained from: Trento Italy site
grass binary for platform: Compiled from Sources
GRASS Version: 5.0.1

The color names reported in the right column of the Color Menu in v.digit
don't meet the colors displayed in the monitor.
Aldo Clerici
***************************************************************
I found a solution to this a few days ago and I'm working on generating a
patch.