[GRASS5] Re: [GRASS-CVS] glynn: grass51/general/g.parser main.c,2.0,2.1

Glynn Clements glynn at gclements.plus.com
Sat Dec 4 15:40:02 EST 2004


Markus Neteler wrote:

> does the change below affect existing GRASS scripts?

> > -	sprintf(buff, "GIS_OPT_%s=%s", option->key, option->answer);
> > +	sprintf(buff, "GIS_OPT_%s=%s", option->key, option->answer ? option->answer : "");

The only way in which it could affect existing scripts is if they are
doing e.g.:

	if [ $GIS_OPT_something = '(null)' ] ; then
		...

which is probably a bug. I'm not sure that sprintf(buff, "%s", NULL)
is guaranteed to generate "(null)".

However, there is at least one script (i.image.mosaic) which expects a
missing argument to result in $GIS_OPT_* being the empty string.

N.B.: this is a fix for bug #2740.

-- 
Glynn Clements <glynn at gclements.plus.com>




More information about the grass-dev mailing list