[GRASS5] d.vect.thematic committed to CVS

[Michael Barton]

Fixed in CVS this morning. See below for details.
______________________________
Michael Barton, Professor of Anthropology
School of Human Evolution and Social Change
Arizona State University
Tempe, AZ  85287-2402
USA

voice: 480-965-6262; fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton


> From: Hamish <hamish_nospam at yahoo.com>
> Date: Fri, 13 May 2005 15:04:55 +1200
> To: Michael Barton <michael.barton at asu.edu>
> Cc: <grass5 at grass.itc.it>
> Subject: Re: [GRASS5] d.vect.thematic committed to CVS
> 
>> I fixed a few small bugs and committed d.vect.thematic and v.univar.sh
>> to the CVS.
> 
> 
> 
> both:
> 
> - to "activate" new modules, you need to add them to the parent
> Makefile, e.g. grass6/scripts/Makefile.

Fixed

> 
> 
> - Instead of a table= option, parse the output of v.db.connect -g (or -p)
> to get the answer automatically. I see you have commented out in thematic:
> #v.db.connect map=fields2 -pg
> note -pg isn't correct, choose one or the other. If this doesn't show
> the correct table then it is a bug & should be fixed.

Not needed given how v.univar.sh is done now

> 
> 
> v.univar.sh:
> 
> please keep option names consistent with other modules, e.g. 'db.connect
> driver= database=' instead of drv= and db=.
> 
> 
> d.vect.thematic:
> 
> get rid of "#% key: icon"  options line. Why restrict?
> G> ls $GISBASE/etc/symbol/*

No change for now. Working on a more sophisticated way to do this.

> 
> 
> colorscheme=
>  I'm a huge fan of blue->cyan->yellow->red. Why not let it be any of the
> colorschemes in $GISBASE/etc/colors/? (ok, very hard to parse in a shell
> script)
> 

No change for now. Working on a more sophisticated way to do this.

> 
> if [ "$OPT_GIS_table" = "" ] ; then
>  use instead:  (probably breaks on cygwin)
> if [ -z "$OPT_GIS_table" ] ; then

Fixed

> 
> 
> min="`grep 'Minimum:' TMP1 | sed s/Minimum://`"
> max="`grep 'Maximum:' TMP1 | sed s/Maximum://`"
> mean="`grep 'Mean:' TMP1 | sed s/Mean://`"
> etc.
> change TMP1 -> "$TMP1"
> 
> Always try to "quote" file names. (spaces in names, etc)

This doesn't work with "$TMP1". Kept TMP1.

> 
> 
>  themecolor=$color1":"$color2":"$color3
> to
>  themecolor="$color1:$color2:$color3"
> 
> (not a big deal, just cleaner)

Fixed

Also fixed 'legend' output to make it more readable.

> 
> 
> .. and that's about as far as I got through an audit.
> 
> 
> nice work,
> 
> 
> Hamish