[GRASS5] Re: Open GRASS issues

[Markus Neteler]

On Wed, Jan 25, 2006 at 03:19:34PM +0100, Markus Neteler wrote:
> (cc list)
> 
> On Wed, Jan 25, 2006 at 02:09:09PM +0000, Glynn Clements wrote:
> > 
> > Markus Neteler wrote:
> > 
> > > > > I would like to ask you for help with the zlib issue.
> > > > > For me it's a showstopper, also blocking 6.0.2.
> > > > > Do you see a chance to look into this?
> > > > 
> > > > Try the attached patch; it fixes your test case and a few similar
> > > > cases (e.g. 10x10, 9x9 etc, constant value).
> > > 
> > > It happened for all maps below 13x13 (or 12x12, not tested).
> > > With your patch it's fixed.
> > > 
> > > Will you submit it?
> > 
> > Done.
> > 
> > > It should also go into 6.0, right?
> > 
> > If GRASS_INT_ZLIB is present in 6.0.x, then the fix needs to go in.
> 
> Done.
> 
> 
> But: It also exists in GRASS 5:
> cvsgrass53> grep GRASS_INT_ZLIB ./src/libes/gis/opencell.c
>         COMPRESSION_TYPE = getenv("GRASS_INT_ZLIB") ? 2 : 1;
> 
> http://freegis.org/cgi-bin/viewcvs.cgi/grass/src/libes/gis/put_row.c
> 
> I have tried locally:
> patch -p2 < ~/zlib.patch
> patching file put_row.c
> 
> 'patch' doesn't complain. Should I submit (also for the next 5.4.x release
> managed by Paul)?

I have submitted the patch to GRASS 5-CVS as well.

Markus