[GRASS-dev] Re: [bug #4905] (grass) gis.m: d.text.freetype does not allow spaces in text

Glynn Clements glynn at gclements.plus.com
Tue Sep 19 08:20:42 EDT 2006


Glynn Clements wrote:

> Most graphics operations don't actually return any status. The only
> R_* functions whose return value actually reflects a status code from
> the driver are:
> 
> 	R_open_driver
> 
> 	R_color_table_float
> 	R_color_table_fixed
> 
> 	R_font
> 	R_font_freetype
> 	R_charset
> 	R_font_freetype_release
> 
> [R_screen_* return a value, not status (they can't fail), while
> R_get_num_colors and R_get_location_with_* store the values via
> pointers which are passed as arguments.]
> 
> Of the above, R_open_driver is probably the only case where programs
> generally bother to check the value.
> 
> Actually, there's no "probably"; I've just checked, and everything
> which uses one of the above font/colour-table functions ignores the
> return code.
> 
> Also, only two programs (d.text.freetype and i.class) use
> R_color_table_fixed. As nothing uses R_color_table_float (d.colormode
> isn't present in 6.x), and the driver starts in fixed mode, both of
> those functions are redundant.
> 
> In that case:
> 
> 1. I intend to remove the status returns from all R_* functions except
> for R_open_driver.

I did this a while ago.

> 2. Unless someone objects, I also intend to remove R_color_table_* and
> their associated infrastructure, including all of the driver code
> related to floating colour mode. That will remove a significant chunk
> of the complexity of the display architecture, and make it
> significantly easier to understand.

I've now done this.

The following R_*/D_* functions no longer exist:

	R_color_table_float
	R_color_table_fixed
	R_color_offset
	D_claim_offset_is
	D_offset_is

-- 
Glynn Clements <glynn at gclements.plus.com>




More information about the grass-dev mailing list