[GRASS-dev] ps.map fprintf -> G_

Martin Landa landa.martin at gmail.com
Mon Jan 8 09:50:49 EST 2007


Hi,

2007/1/8, Moritz Lennert <mlennert at club.worldonline.be>:

> Hamish wrote:
> > pps- ps.map verbose command IS used in the wild, so don't break scripts by
> > removing it altogether. Note it is multi-leveled, so it should keep at least 3
> > levels of verbosity triggered by --q,<>,--v, i.e. standard messages should use
> > G_message(), but very verbose messages should hide G_message() in if(verbose >=
> > G_max_verbose()) or whatever. I am in favour of separating mapping commands
> > from program control, and letting the parser deal with the latter.

I am not sure if I understand well. It is true that verbose mapping
instruction is multi-leveled (0|1|2). But in practice there was only
one condition: if (verbose > 1) fprintf ();. It would be good to
distinguish between standard and verbose messages as Hamish suggested.
 I am not sure what messages are "standard" and "very verbose".

In the first patch verbose instruction overwrote the --v/q flags [1],
now verbose instruction was removed and added a warning about that. So
should I apply rather the first approach (including G_set_verbose) ?

Martin


[1] http://grass.itc.it/pipermail/grass-dev/2006-December/028272.html
-- 
Martin Landa <landa.martin at gmail.com> * http://gama.fsv.cvut.cz/~landa *




More information about the grass-dev mailing list