[GRASS-dev] Re: Directory security/permission issue

[Markus Neteler]

Glynn Clements wrote:
> 
>                      object                      | symbol 
> -------------------------------------------------+--------
>  general/g.tempfile/OBJ.i686-pc-linux-gnu/main.o | umask
>  lib/gis/OBJ.i686-pc-linux-gnu/gisinit.o         | umask
>  lib/init/OBJ.i686-pc-linux-gnu/set_data.o       | umask
>  lib/init/OBJ.i686-pc-linux-gnu/lock.o           | umask
> (4 rows)
> 
> lib/gis/gisinit.c has umask(022), while the others all have umask(0). 
> Every single one of these is wrong. The umask is for the user;
> programs should leave it alone.
> 
> I've removed all four umask() calls from CVS.
> 
> Also, lib/init/init.sh had two occurrences of:
> 
> 	echo "umask 022" >> "$bashrc"
> 
> which I have removed.
> 
> The remaining occurrence:
> 
> 	tmp=/tmp/grass6-$USER-$GIS_LOCK
> 	(umask 077 && mkdir "$tmp") || {
> 
> has been retained, although I'm not sure why this doesn't just use
> "mkdir -m 007" rather than (temporarily) setting the umask.
> 
> -- 
> Glynn Clements <glynn at gclements.plus.com>
> 

I have backported this to GRASS 6.2.CVS (for 6.2.2).

Markus
-- 
View this message in context: http://www.nabble.com/Directory-security-permission-issue-tf4043722.html#a11558689
Sent from the Grass - Dev mailing list archive at Nabble.com.