[GRASS-dev] small patch for lib/vector/transform/

[Dylan Beaudette]

On Saturday 02 June 2007 20:12, Glynn Clements wrote:
> Dylan Beaudette wrote:
> > > First, patches should use either unified or context format (preferably
> > > unified). However ...
> >
> > ok, I will read up on how to do this.
>
> Add the -u or -c flags to "diff" or "cvs diff". For CVS, you can add
> "diff -u" to ~/.cvsrc to make it the default.
>
> Some useful ~/.cvsrc settings:
>
> 	cvs -z3
> 	checkout -P
> 	update -dP
> 	diff -u
>
> > > Library code shouldn't be unconditionally printing diagnostic
> > > information (especially not to stdout); use G_debug() instead.
> >
> > good call, that was definitely bad style on my part. Instead of debug, a
> > flag might be a good option?
>
> Within the module, you can use G_verbose_message() for messages which
> should only printed when --verbose is used. Or you could add a
> specific flag.
>
> The main point is that library code shouldn't have undesirable
> side-effects. What is desirable varies between modules, so library
> functions generally shouldn't do anything "extra"; that should be done
> by individual modules.

Thanks for the tips Glynn. I have re-submitted some new ideas to the dev list.

-- 
Dylan Beaudette
Soils and Biogeochemistry Graduate Group
University of California at Davis
530.754.7341