[GRASS-dev] [bug #5499] (grass) bash scripts starting with #!/bin/sh

[Daniel Calvelo]

On 3/18/07, Maciek Sieczka via RT <grass-bugs at intevation.de> wrote:
> Hi!

Hi Maciek.

> I have found checkbashisms script. In Debian and alike it's provided with
> devscripts package. Version 2.9.10 run on GRASS scripts from 6.3 CVS
> 18.03.2007 yields following warnings. I'm no expert and can't say which are
> real. Just letting others know.
>
> $ grass63
>
> $ for i in `ls /usr/local/grass-6.3.cvs/scripts/`; do checkbashisms
> /usr/local/grass-6.3.cvs/scripts/$i; done
>
> possible bashism in /usr/local/grass-6.3.cvs/scripts/d.correlate line 75: '[
> "$name" == '
> possible bashism in /usr/local/grass-6.3.cvs/scripts/d.correlate line 81: '[
> "$ok" == '
> possible bashism in /usr/local/grass-6.3.cvs/scripts/d.polar line 137: '[
> $TOTALVALIDNUMBER == '
> possible bashism in /usr/local/grass-6.3.cvs/scripts/g.mlist line 118: '[
> "$itype" == '

Those are done, and on CVS.

> possible bashism in /usr/local/grass-6.3.cvs/scripts/i.in.spotvgt line 200:
> '${NAME}_$PID,${NAME}'

This is a false positive, it is an argument to g.rename

> script /usr/local/grass-6.3.cvs/scripts/r.tileset is already a bash script;
> skipping
> possible bashism in /usr/local/grass-6.3.cvs/scripts/r.univar.sh line 116:
> 'function abs'
> possible bashism in /usr/local/grass-6.3.cvs/scripts/v.univar.sh line 147:
> 'function abs'

Those are false positives; the functions are defined within inlined awk scripts.

> Maciek
>
>
> -------------------------------------------- Managed by Request Tracker
>
> _______________________________________________
> grass-dev mailing list
> grass-dev at grass.itc.it
> http://grass.itc.it/mailman/listinfo/grass-dev
>


-- 
-- Daniel Calvelo Aros