[GRASS-dev] Re: [GRASS GIS] #392: backport G_is_c_null_value() to devbr6

[GRASS GIS]

#392: backport G_is_c_null_value() to devbr6
----------------------+-----------------------------------------------------
  Reporter:  hamish   |       Owner:  grass-dev at lists.osgeo.org
      Type:  task     |      Status:  new                      
  Priority:  major    |   Milestone:  6.4.0                    
 Component:  default  |     Version:  svn-develbranch6         
Resolution:           |    Keywords:                           
  Platform:  All      |         Cpu:  All                      
----------------------+-----------------------------------------------------
Comment (by glynn):

 Replying to [comment:1 hamish]:

 > I am trying to see which changes are needed here,
 >  http://trac.osgeo.org/grass/log/grass/trunk/lib/gis/null_val.c
 >
 > you say r34445, r34484 are not needed, and r34446 is a fix to r34445, so
 I guess skip that too.

 Actually r34445 is the main change which should be applied, but that
 requires both r34446 and r34747, but r34747 probably won't apply without
 r34484, but r34484 needs the corresponding changes to gisdefs.h, but only
 for null_val.c, unless you're going to apply r34484 to all 72 files.

 > that leaves r34747 -- but things are different in 6.4. Possible patch
 attached, but I'm not really sure of the nature of the bug to know if it's
 right or not.

 No. "(CELL) &cellNullPattern" isn't valid. If you want to retain the
 existing byte arrays as the reference values, you would need to retain the
 existing code (or use memcmp).

 I suggest completely replacing null_val.c with the 7.0 version, and
 editing gisdefs.h to match. Either that, or leave it as-is.

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/392#comment:2>
GRASS GIS <http://grass.osgeo.org>