[GRASS-dev] Re: [GRASS GIS] #39: r.in.srtm fails to validate zip files

[Hamish]

> > #39: r.in.srtm fails to validate zip files

Hamish:
> > re "why was it changed" in r19303: it never used `zip` to test, it
> > was  using `ls` to look for a file with a .zip extension. (input=
> > refers to the tile name not the file name)
....

> >  for one thing "echo $foo.zip | grep zip" was always true.

oops, wrong. that was used as a 'if [ -f ${FILE}.zip ] ;'  test.
Not like echo as the file wasn't guaranteed to be there.

> > Perhaps the reason for the test had to do with downloaders
> > creating incomplete or 0 byte files, or having wrongly named files?

No, the module built the input filename internally, and was checking
that it came up with a correct filename. Getting mime type from `file`
was just a more advanced form of that.

Glynn:
> If incomplete downloads are an issue,

probably not. It will exit with an error if the unzip step fails.


> >  I've removed `file` and added a call to `unzip -t` in 6.3 trunk.

and I think that should be fine.

> > waiting to backport to 6.3.0's branch and close the bug until
> > someone tests the change please.

....


Hamish



      ____________________________________________________________________________________
Be a better friend, newshound, and 
know-it-all with Yahoo! Mobile.  Try it now.  http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ