[GRASS-dev] adding lib_arraystats

[Paul Kelly]

Hi Moritz,

On Wed, 13 Feb 2008, Moritz Lennert wrote:

> On 11/02/08 23:29, Moritz Lennert wrote:
>> Hello,
>> 
>> I've finally gotten around to continue working on the d.thematic.* modules, 
>> and more specifically on the classification code. As mentioned earlier, I 
>> think it makes sense to make the latter into a library, so I decided to 
>> create lib_arraystats which contains functions for collecting basic 
>> statistics and for finding class breaks in arrays of doubles. In the future 
>> this could be filled with more statistical functions on such arrays.
>> 
>> Could the gurus please have a look and tell me if the attached files are 
>> decent enough (except for the lacking documentation) to be committed to svn 
>> for further development ? Once that's done, I can also commit the 
>> d.thematic.area and v.class modules.
>
> I'm happy that I've been able to launch a discussion about linking R into 
> GRASS, but could someone tell me if I can check the code into svn ?

I can't presume to say anything other than if you feel happy the quality 
and functionality is up to inclusion in GRASS, go ahead - but if you'd 
like a couple of comments on it here goes:

the typedef STATS looks a little weird to me, (a) because STATS on its own 
is a very generic sounding name and (b) because in general typedefs are 
used very little in GRASS (for one thing they confuse me...) I'd suggest 
something along the lines of "struct GASTATS", avoiding the typedef.

EXIT_SUCCESS used as a function exit status looks a bit strange to me too- 
IIUC this is defined in stdlib.h and intended for programs to return a 
status code to the enviroment when they exit, not really for internal use 
by functions.

But I guess they're minor issues - just trying to find something useful to 
say..

Paul