[GRASS-dev] Re: [GRASS GIS] #197: sfd support for r.terraflow

GRASS GIS trac at osgeo.org
Tue Jul 1 22:23:43 EDT 2008


#197: sfd support for r.terraflow
--------------------------+-------------------------------------------------
  Reporter:  adanner      |       Owner:  grass-dev at lists.osgeo.org
      Type:  defect       |      Status:  new                      
  Priority:  major        |   Milestone:  7.0.0                    
 Component:  Raster       |     Version:  svn-trunk                
Resolution:               |    Keywords:  terraflow r.terraflow    
  Platform:  Unspecified  |         Cpu:  Unspecified              
--------------------------+-------------------------------------------------
Comment (by adanner):

 Replying to [comment:9 glynn]:
 > Replying to [comment:8 adanner]:
 >
 > > > Correct. Which is why the interface needs to be fixed in C; i.e. add
 the "const" to the fields of "struct Option" in gis.h. Having the compiler
 remind people about this on a regular basis is the best way to make it
 happen.
 > > >
 > > > Actually, I'll look into that side of it now.
 > >
 > > Thanks, that eliminates many of the warnings. There are only four left
 on options->answer, but I'm content with only four warnings. Fixing those
 last four require some tedious buffer creation/copying.
 >
 > It should suffice to use:
 >
 > opt->answer = G_store("literal");
 >

 Another rounds of updates to the patch to use G_store. It works great for
 r.terraflow which now compiles against gcc 4.2.3 with zero warnings.
 Thanks for your help.

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/197#comment:10>
GRASS GIS <http://grass.osgeo.org>


More information about the grass-dev mailing list