[GRASS-dev] GRASS 7 development started

[Markus Neteler]

On Sat, Jun 21, 2008 at 1:54 PM, Glynn Clements
<glynn at gclements.plus.com> wrote:
> Markus Neteler wrote:
>
>> do you have the ultimate "indent" line for me?
>
> indent -bad -bap -bbb -br -bli0 -bls -cli0 -ncs -fc1 -hnl -i4 \
>       -nbbo -nbc -nbfda -nbfde -ncdb -ncdw -nce -nfca -npcs -nprs \
>       -npsl -nsc -nsob -saf -sai -saw -sbi0 -ss -ts8 -ut

I have done a test run locally and came across a problem:

cd visualization/nviz/src
 indent -bad -bap -bbb -br -bli0 -bls -cli0 -ncs -fc1 -hnl -i4 \
       -nbbo -nbc -nbfda -nbfde -ncdb -ncdw -nce -nfca -npcs -nprs \
       -npsl -nsc -nsob -saf -sai -saw -sbi0 -ss -ts8 -ut togl_flythrough.c

indent: togl_flythrough.c:609: Warning:old style assignment ambiguity
in "=-".  Assuming "= -"
indent: togl_flythrough.c:956: Error:Unexpected end of file

Additionally, there are:

indent: ./lib/vector/dglib/misc-template.c:546: Error:Stmt nesting error.
indent: ./lib/vector/dglib/misc-template.c:623: Error:Unmatched 'else'
indent: ./lib/vector/dglib/misc-template.c:649: Error:Stmt nesting error.
indent: ./swig/perl/grass_wrap.c:1064: Error:Stmt nesting error.

and several warnings like
indent: ./lib/sites/sites.c:859: Warning:old style assignment
ambiguity in "=-".  Assuming "= -"
and
indent: ./lib/rst/interp_float/vinput2d.c:75: Warning:old style
assignment ambiguity in "=*".  Assuming "= *"


Analysing one of the 'Assuming "= -"' warnings, it turns out that:
                    site->cattype=-1;
is changed to
                    site->cattype = -1;
but it should be
                    site->cattype =- 1;
Can we trap this? Otherwise we can run it locally and fix all warnings
manually in SVN
before running the global automated indenting.

Note: the indent line is now available as script(s) in trunk:
tools/grass_indent.sh
tools/grass_indent_ALL.sh

We need to fix above files first (manually but how), then I would like to run
and submit the entire indentation over next weekend.

Markus