[GRASS-dev] Re: [GRASS GIS] #278: wxGUI: don't allow for negative column number

GRASS GIS trac at osgeo.org
Fri Nov 28 19:43:27 EST 2008


#278: wxGUI: don't allow for negative column number
-----------------------+----------------------------------------------------
  Reporter:  msieczka  |       Owner:  martinl  
      Type:  defect    |      Status:  assigned 
  Priority:  minor     |   Milestone:  7.0.0    
 Component:  wxGUI     |     Version:  svn-trunk
Resolution:            |    Keywords:  parser   
  Platform:  All       |         Cpu:  All      
-----------------------+----------------------------------------------------
Changes (by hamish):

  * priority:  major => minor
  * version:  svn-develbranch6 => svn-trunk
  * milestone:  6.4.0 => 7.0.0

Comment:

 the syntax is still a bit complicated / vague / tricky to me, e.g. how to
 set int_opt=-1 when you want to set just -1.0?

 is the patch to help the programmer set opt_xcol->options = ">=1"; ?
 if so, why not add some magic code to parse <>= instead of a new &
 unintuitive "--1" "-1-" syntax? (ie not to say it is broken, just that it
 fails the transferable knowledge test badly)

 for v.in.ascii, column >=0 checks added in r34608, r34609.

 At this stage, we should not make new non-critical changes to
 lib/gis/parser.c in devbr6 IMHO. As the specific reported issue of
 v.in.ascii is fixed, changing bug's target to g7.

 I leave GUI spinbox controls to others, but guess that it is dependent on
 parser support for ->options as above.


 Hamish

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/278#comment:4>
GRASS GIS <http://grass.osgeo.org>


More information about the grass-dev mailing list