[GRASS-dev] Testing needed for v.buffer2

[Росен Матев]

I've removed the C99 calls.

On Wed, Sep 10, 2008 at 3:23 AM, Glynn Clements
<glynn at gclements.plus.com> wrote:
>
> Martin Landa wrote:
>
>> > My mentor Wolf and I are experiencing problems with the new buffer
>> > module. For some certain input it works well on my system but doesn't
>> > finish at all on Wolf's. We need some help to figure out what's
>>
>> [...]
>>
>> hm strange, I cannot compile v.buffer2
>>
>> gcc -I/home/landa/src/grass6_devel/dist.i686-pc-linux-gnu/include
>> -Wall -Werror-implicit-function-declaration -fno-common -Wextra
>> -Wunused    -I/home/landa/usr/include    -DPACKAGE=\""grassmods"\"
>> -I/home/landa/src/grass6_devel/dist.i686-pc-linux-gnu/include -o
>> OBJ.i686-pc-linux-gnu/e_intersect.o -c e_intersect.c
>> e_intersect.c: In function 'segment_intersection_2d_tol':
>> e_intersect.c:352: error: implicit declaration of function 'fmax'
>> e_intersect.c:352: warning: incompatible implicit declaration of
>> built-in function 'fmax'
>> e_intersect.c:369: error: implicit declaration of function 'fmin'
>> e_intersect.c:369: warning: incompatible implicit declaration of
>> built-in function 'fmin'
>>
>> fmax and fmin should be declared in math.h (which is included) ...
>
> fmax/fmin are C99. You may need to use e.g. -D_ISOC99_SOURCE in order
> for them to be available.
>
> This should be fixed (i.e. replace with a macro) before the code is
> moved into the main tree. We shouldn't require C99 unnecessarily (and
> this is unnecessary).
>
> --
> Glynn Clements <glynn at gclements.plus.com>
>