[GRASS-dev] lib/form/ and Tcl 8.6 compile problem

[Markus Neteler]

On Wed, Jan 21, 2009 at 6:15 PM, Markus Neteler <neteler at osgeo.org> wrote:
> On Wed, Jan 21, 2009 at 5:58 PM, Maris Nartiss <maris.gis at gmail.com> wrote:
>> In short - no one has eliminated old tcl/tk versions out there. Any
>> patch needs to work with old and new approach too. Also forms isn't
>> the only place where interp result is used (lazy to grep)
>
> This is the list:
> ./lib/form/form.c
> ./vector/v.digit/form.c
> ./visualization/nviz/src/anim_support.c
> ./visualization/nviz/src/cutplane_obj.c
> ./visualization/nviz/src/do_zoom.c
> ./visualization/nviz/src/draw.c
> ./visualization/nviz/src/exag.c
> ./visualization/nviz/src/lights.c
> ./visualization/nviz/src/map_obj.c
> ./visualization/nviz/src/misc.c
> ./visualization/nviz/src/mkdspf_main.c
> ./visualization/nviz/src/nvizAppInit.c
> ./visualization/nviz/src/nviz_init.c
> ./visualization/nviz/src/position.c
> ./visualization/nviz/src/togl_flythrough.c
> ./visualization/nviz/src/volume.c
>
> I am willing to fix it if someone tells me how.
>
> The lack of ./lib/form/form.c fix breaks some more modules,
> so that's of priority.

I see
http://www.tcl.tk/cgi-bin/tct/tip/330.html
http://www.nabble.com/Re:-TIP--330-and-(void)-Tcl_GetStringResult(interp)-calls-in-the-core-td21045974.html

Please :)
Nobody can tell me how to fix this?

Is it this?
http://wiki.tcl.tk/1564

Index: lib/form/form.c
===================================================================
--- lib/form/form.c     (revision 35532)
+++ lib/form/form.c     (working copy)
@@ -192,7 +192,7 @@
                    TCL_ERROR) {
                    G_warning
                        ("Could not set Tcl system encoding to '%s' (%s)",
-                        Columns[i].value, interp->result);
+                        Columns[i].value, Tcl_GetStringResult(interp));
                }
            }
            continue;

?

Markus