[GRASS-dev] lib/init/grass.py r37899

Glynn Clements glynn at gclements.plus.com
Thu Jun 18 14:19:06 EDT 2009


What is the intent of this change?

--- lib/init/grass.py	(revision 37898)
+++ lib/init/grass.py	(revision 37899)
@@ -591,9 +591,10 @@
     
     # Check for gui interface
     if grass_gui == "wxpython":
-	call([os.getenv('GRASS_PYTHON'),
-              gfile("etc", "wxpython", "wxgui.py")])
-
+        subprocess.Popen([os.getenv('GRASS_PYTHON'),
+                          gfile("etc", "wxpython", "wxgui.py")],
+                         stdout=subprocess.PIPE)
+    

Using subprocess.PIPE when nothing can read from the pipe is a bug.

If output should go to the terminal, stdout shouldn't be set. If
output should be discarded, use os.devnull (see check_gui for example
usage).

-- 
Glynn Clements <glynn at gclements.plus.com>


More information about the grass-dev mailing list