[GRASS-dev] Re: [GRASS GIS] #224: cache bug in DGLib
GRASS GIS
trac at osgeo.org
Wed Mar 4 12:46:35 EST 2009
#224: cache bug in DGLib
----------------------+-----------------------------------------------------
Reporter: martinl | Owner: grass-dev at lists.osgeo.org
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: Vector | Version: svn-develbranch6
Resolution: | Keywords: vector, dglib, cache
Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by mmetz):
Replying to [comment:6 mlennert]:
> Replying to [comment:4 mmetz]:
> > dglib cache back to life in trunk r36113 and devbr6 r36114
> >
> > testing is very welcome!
>
> Still need to look at the actual results more in detail (look good at
rough glance). Also ran a few v.net.path's and everything seems fine.
The critical values are the costs returned by Vect_net_shortest_path(). I
did my testing by inserting
fprintf(stdout, "%f\n", cost);
e.g. in v.net.iso/main.c line 254 and v.net.alloc/main.c line 214
then with cache enabled: v.net.iso >costs.cache, similar for cache
disabled
I have added comments in lib/vector/Vlib/net.c explaining how to
disable/enable the cache. The comments and relevant code are in lines 489
- 504. Note that there is no need to comment out line 436.
>
> Concerning BUG2: Maybe we could think of some test cases ?
For BUG1, I created a test vector as described in dglib/BUGS. It should
not be too difficult to create a test vector for BUG2, but unfortunately I
have not the faintest idea where to start poking around in dglib. I really
tried to understand where and how the arcs are inserted, and by now I
think I'm not that bad in understanding source code, but this is beyond
me. You're welcome to get your hands dirty with dglib yourself:-)
Markus M
--
Ticket URL: <http://trac.osgeo.org/grass/ticket/224#comment:7>
GRASS GIS <http://grass.osgeo.org>
More information about the grass-dev
mailing list