[GRASS-dev] WPS XML process description added to lib/gis/parser.c

[Soeren Gebbert]

Hi,

2009/11/26 Glynn Clements <glynn at gclements.plus.com>:
>
> Soeren Gebbert wrote:
>
>> I have added the generation of WPS process description XML documents
>> to lib/gis/parser.c in grass7 .
>
> We should probably split parser.c into multiple files. At ~84KiB, it's
> easily the largest file in lib/gis.
>
> Each of the "description" options (--help, --interface-description,
> --html-description, --wps-process-description, --script) should
> probably be in a separate file.

Done.
I have split parser.c in the following files:
-rw-r--r-- 1 soeren users 30041 parser.c
-rw-r--r-- 1 soeren users  5695  parser_help.c
-rw-r--r-- 1 soeren users  6180  parser_html.c
-rw-r--r-- 1 soeren users  7237  parser_interface.c
-rw-r--r-- 1 soeren users  1591  parser_local_proto.h
-rw-r--r-- 1 soeren users  3549  parser_script.c
-rw-r--r-- 1 soeren users 10912 parser_standard_options.c
-rw-r--r-- 1 soeren users 22265 parser_wps.c

Code review is very welcome, i am always confused about the usage of
external variable.

>
>> Any hints, criticism and suggestions are welcome.
>
> A couple of minor points regarding e.g.:

Thanks.

>
>        static void wps_print_ProcessDescription()
>
> 1. Functions should use ANSI C prototypes, which means using "void"
> for the argument list if the function takes no arguments.

Sorry! done.

>
> 2. We don't use CamelCase.
>
> IOW:
>
>        static void wps_print_process_description(void)
>

Done. (i thought naming parts of the functions exactly like the XML tags is more
important than the code convention ...)


Best regards
Soeren

ps:
I have attached the source files, because i am unable to contact the
grass svn server.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parser.c
Type: text/x-csrc
Size: 29995 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/grass-dev/attachments/20091126/568967ac/parser-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parser_help.c
Type: text/x-csrc
Size: 5694 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/grass-dev/attachments/20091126/568967ac/parser_help-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parser_html.c
Type: text/x-csrc
Size: 6179 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/grass-dev/attachments/20091126/568967ac/parser_html-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parser_interface.c
Type: text/x-csrc
Size: 7236 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/grass-dev/attachments/20091126/568967ac/parser_interface-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parser_local_proto.h
Type: text/x-chdr
Size: 1670 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/grass-dev/attachments/20091126/568967ac/parser_local_proto-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parser_script.c
Type: text/x-csrc
Size: 3548 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/grass-dev/attachments/20091126/568967ac/parser_script-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parser_standard_options.c
Type: text/x-csrc
Size: 10911 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/grass-dev/attachments/20091126/568967ac/parser_standard_options-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parser_wps.c
Type: text/x-csrc
Size: 22264 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/grass-dev/attachments/20091126/568967ac/parser_wps-0001.bin