[GRASS-dev] Re: gui_modules/colorrules.py bug and wishes (Markus Neteler)

[Michael Barton]

On Oct 28, 2009, at 2:23 AM, grass-dev-request at lists.osgeo.org wrote:

> Send grass-dev mailing list submissions to
> 	grass-dev at lists.osgeo.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> 	http://lists.osgeo.org/mailman/listinfo/grass-dev
> or, via email, send a message with subject or body 'help' to
> 	grass-dev-request at lists.osgeo.org
>
> You can reach the person managing the list at
> 	grass-dev-owner at lists.osgeo.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of grass-dev digest..."
>
>
> Today's Topics:
>
>   1. gui_modules/colorrules.py bug and wishes (Markus Neteler)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Wed, 28 Oct 2009 10:22:37 +0100
> From: Markus Neteler <neteler at osgeo.org>
> Subject: [GRASS-dev] gui_modules/colorrules.py bug and wishes
> To: GRASS developers list <grass-dev at lists.osgeo.org>
> Message-ID:
> 	<86782b610910280222re95a0d5yb2f464499d3ab653 at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Hi,
>
> trying "volors" (i.e., gui_modules/colorrules.py) I found small bug  
> and
> got a few ideas to improve this promising dialog.
> Please see attached screenshot as I found it easier to indicate the
> ideas there.
>
> Those which aren't easy to fix I'll submit later as tickets.
>
> thanks
> Markus

Hi Markus,

Interesting. The bug you've found is not the one you think you found ;-)

Both menu items "color rules" and "color tables" under vector->manage  
colors are bringing up the same color rules module from wxGUI.  
Instead, "color tables" should be bringing up the interface for the  
new v.colors GRASS module. I suspect it's just a typo in the menu  
string.

The vector color rules module does not do what you are assuming it  
does. That is, it does not automatically spread a color gradient  
between a max and min value. What it does is allow you to custom set  
colors to individual values or ranges of values, and store these  
colors in the GRASSRGB color column. The add column button may not be  
too hard to implement (automatically refreshing the column list may be  
the biggest headache). The other suggestions don't match this module.  
This module was written before v.colors and has different functionality.

The functions you thought were in the color rules wxGUI module are  
actualy in the v.colors GRASS module. The "color tables" menu option  
ought to call this module. It automatically sets max and min, but also  
allows the user to set custom max/min. It then lets you pick a color  
table and automatically assign the color gradients to the vector values.

I'll try to get this fixed when I get to my office today. Hopefully  
it's a simple typo.

Michael