[GRASS-dev] Re: [GRASS GIS] #734: wxGui sqlbuilder: a few bugs

[GRASS GIS]

#734: wxGui sqlbuilder: a few bugs
---------------------+------------------------------------------------------
  Reporter:  hamish  |       Owner:  martinl   
      Type:  defect  |      Status:  assigned  
  Priority:  major   |   Milestone:  6.4.0     
 Component:  wxGUI   |     Version:  6.4.0 RCs 
Resolution:          |    Keywords:  sqlbuilder
  Platform:  Linux   |         Cpu:  x86-64    
---------------------+------------------------------------------------------
Comment (by hamish):

 Much better...!


 fine tuning / feedback:

  - Columns and Values text boxes are now a bit too small, only showing 1.5
 column names + up/down slider. It would be nice if it were big enough to
 at least show more of them.

  - it says "Add on double click" but actually it adds column name on
 single click. Or if you have a column name selected from the list and on
 the keyboard do up-down-up-down arrows it repeatedly adds those column
 names in the Query text box. Rename as "Add on double click as"? Before a
 little experimentation I find it hard to know what those radio buttons
 did. Possible to have a tooltip there?

  - shouldn't the base text end with "WHERE " ? (ok it shows up once I
 select a column name as "(*)values" but why not have it there to begin
 with?)

  - [Get sample],[Get all values] fail if the map is not in the current
 mapset (e.g. fields at PERMANENT). I had this running recently when it called
 the db.select directly; the trick is to pass db.* the full path to the
 database table the 4th column from 'v.db.connect -p', or use v.db.select.
 In the terminal shell window:
 {{{
 DBMI-DBF driver error:
 Table 'fields' doesn't exist.
 Error in db_open_select_cursor()

 ERROR: Fetching data from table <fields> failed
 }}}


  - open SQL builder for fields at PERMANENT, click on Columns: _cat_, click
 on [Close]. you get this error in the main Layer Manager output tab:
 {{{
 Traceback (most recent call last):
   File "[$GISBASE]/etc/wxpython/gui_modules/sqlbuilder.py",
 line 321, in OnAddColumn

 if not self.btn_uniquesample.IsEnabled():
   File "/usr/lib/python2.5/site-
 packages/wx-2.8-gtk2-unicode/wx/_core.py", line 14314, in
 __getattr__

 raise PyDeadObjectError(self.attrStr % self._name)
 wx._core
 .
 PyDeadObjectError
 :
 The C++ part of the Button object has been deleted,
 attribute access no longer allowed.
 }}}

  - uncheck "Close dialog on apply" by default? (match module GUI
 behaviour) It's just a bit surprising when it vanishes. Or change "Apply"
 to "Accept"?

  - Verify: show result in pop up window instead of status bar text? It's a
 bit less subtle, and the user did ask for reassurance. Or maybe better
 change the color of the text in the status bar:
  -- not verified: dark orange or dark yellow
  -- verified: changes to dark green
  -- invalid: changes to dark red.
 also as soon as you type/add more into the Query box it should reset to
 "not verified".


 thanks,
 Hamish

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/734#comment:2>
GRASS GIS <http://grass.osgeo.org>