[GRASS-dev] Re: [GRASS-SVN] r42980 - grass/trunk/vector/v.db.connect

[Markus Metz]

That was too fast. There is a problem with the new format. It works
just fine for standard output for one layer, but it has broken some
modules and wxGUI which rely on one line per layer in the form
<layer/name>;<table>;<key>;<database>;<driver>
<layer/name>;<table>;<key>;<database>;<driver>
etc.

I tend to revert it. OK?

Markus M


Markus Metz wrote:
> Martin Landa wrote:
>> Hi,
>>
>> 2010/8/3  <svn_grass at osgeo.org>:
>>>                        else {
>>> -                           fprintf(stdout,
>>> -                                   _("layer <%d> table <%s> in database <%s> through driver "
>>> -                                    "<%s> with key <%s>\n"), fi->number,
>>> -                                   fi->table, fi->database, fi->driver, fi->key);
>>> +                           G_message(_("layer <%d>"), fi->number);
>>>                        }
>>> +                       G_message(_("table <%s>"), fi->table);
>>> +                       G_message(_("in database <%s>"), fi->database);;
>>> +                       G_message(_("through driver <%s>"), fi->driver);
>>> +                       G_message(_("with key <%s>"), fi->key);
>>
>> here I would suggest to use fprintf() instead of G_message(). It's
>> module's output, not messages. E.g. `v.db.connect vzorky -p --q`
>> prints nothing.
>
> Ah ok, I'll fix it.
>
> Markus M
>