[GRASS-dev] Re: [GRASS-SVN] r40881 - in grass/trunk: gui/wxpython/nviz gui/wxpython/vdigit lib/gis visualization/wximgview

[Glynn Clements]

Markus Neteler wrote:

> >> >   grass/trunk/gui/wxpython/nviz/Makefile
> >> >   grass/trunk/gui/wxpython/nviz/setup.py
> >> >   grass/trunk/gui/wxpython/vdigit/Makefile
> >> >   grass/trunk/gui/wxpython/vdigit/setup.py
> >> >   grass/trunk/lib/gis/popen.c
> >> >   grass/trunk/visualization/wximgview/main.cc
> >> > Log:
> >> > Windows fixes
> >>
> >> Do these changes render the digitizer to be usable now?
> >
> > No. MinGW's gcc crashes when trying to link C++ programs. The above
> > changes simply mean that the modules get to the crash-on-link stage
> > rather than failing earlier with compile errors.
> >
> >> A backport candidate?
> >
> > Only popen.c, but I have another change pending for that (G_pager()
> > still doesn't work, although I'm unclear on the reason).
> 
> I am unsure about the popen.c backport since the 6.5 version
> differs significantly from trunk. (same with the recent spaw.c
> fixes).

Right; the popen.c replacement hasn't been back-ported (and probably
shouldn't be), so there's no point in back-porting fixes to it.

FWIW, popen.c should now be entirely unused in 6.5, and may as well be
removed. I replaced all occurrences of G_popen() with popen() in
r40834, and G_pclose() with pclose() in r40921, as G_popen() doesn't
work at all on Windows. These should be back-ported to 6.4 after
testing.

-- 
Glynn Clements <glynn at gclements.plus.com>