[GRASS-dev] Re: [GRASS GIS] #128: NVIZ fails to load vector points without other map

GRASS GIS trac at osgeo.org
Sun Feb 21 07:00:26 EST 2010


#128: NVIZ fails to load vector points without other map
--------------------------+-------------------------------------------------
  Reporter:  neteler      |       Owner:  grass-dev at lists.osgeo.org
      Type:  defect       |      Status:  reopened                 
  Priority:  major        |   Milestone:  6.4.0                    
 Component:  NVIZ         |     Version:  svn-trunk                
Resolution:               |    Keywords:  nviz                     
  Platform:  Unspecified  |         Cpu:  Unspecified              
--------------------------+-------------------------------------------------
Comment (by marisn):

 Replying to [comment:16 hamish]:
 > {{{
 > if (exag < 0.1)
 >     exag = 1.0;
 > }}}
 You are right.  It needs to be changed to GRASS_EPSILON test, as previous
 code read (exag == 0.0) which isn't the best idea for float comparison.
 Still IMHO some code might break if exag is 0 or less.

 > ps- it is much easier to review if cosmetic (whitespace) changes are
 kept to separate patches from bugfixes. signal to noise ratios and all
 that. thanks
 I allways run grass_indent.sh after codding FTW. I will prepeare new
 patches with ignored whitespace changes (thouse where prepeared in 3 AM).

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/128#comment:17>
GRASS GIS <http://grass.osgeo.org>


More information about the grass-dev mailing list