[GRASS-dev] Re: [GRASS GIS] #860: wxGUI: About Copyright missing its middle

[GRASS GIS]

#860: wxGUI: About Copyright missing its middle
-----------------------+----------------------------------------------------
  Reporter:  hamish    |       Owner:  grass-dev at lists.osgeo.org
      Type:  defect    |      Status:  new                      
  Priority:  critical  |   Milestone:  6.4.0                    
 Component:  wxGUI     |     Version:  svn-releasebranch64      
Resolution:            |    Keywords:  license                  
  Platform:  Linux     |         Cpu:  x86-64                   
-----------------------+----------------------------------------------------
Comment (by glynn):

 Replying to [ticket:860 hamish]:

 > when I do help -> about in the 6.4/6.5 wx GUI menu and look in the
 Copyright tab I get the text from `g.region -c`, but only the very top and
 bottom lines. The middle is missing. It skips from the end of the second
 paragraph all the way to "BOSTON, MA ..." & past all the "don't sue us"
 stuff.

 This appears to have been intentional; `AboutWindow.PageCopyright` at
 help.py:458:
 {{{
             copytext = wordwrap(''.join(copyright[:11] +
 copyright[26:-3]),
                                 575, wx.ClientDC(self))
 }}}
 Presumably this was to make it fit the window, but that's not necessary
 now that it's embedded in a `ScrolledPanel`.

 I suggest:
 {{{
 --- gui/wxpython/gui_modules/help.py    (revision 40258)
 +++ gui/wxpython/gui_modules/help.py    (working copy)
 @@ -453,10 +453,7 @@
          copyfile = os.path.join(os.getenv("GISBASE"), "COPYING")
          if os.path.exists(copyfile):
              copyrightFile = open(copyfile, 'r')
 -            copyrightOut = []
 -            copyright = copyrightFile.readlines()
 -            copytext = wordwrap(''.join(copyright[:11] +
 copyright[26:-3]),
 -                                575, wx.ClientDC(self))
 +            copytext = copyrightFile.read()
              copyrightFile.close()
          else:
              copytext = _('%s file missing') % 'COPYING'
 }}}

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/860#comment:1>
GRASS GIS <http://grass.osgeo.org>