[GRASS-dev] Re: [GRASS-SVN] r40647 - in grass/trunk: display/d.title include lib/gis raster/r.out.mpeg raster/r.topmodel visualization/nviz/src visualization/xganim

Glynn Clements glynn at gclements.plus.com
Mon Jan 25 13:35:15 EST 2010


Markus Neteler wrote:

> On Mon, Jan 25, 2010 at 1:20 PM,  <svn_grass at osgeo.org> wrote:
> > Author: glynn
> > Date: 2010-01-25 07:20:13 -0500 (Mon, 25 Jan 2010)
> > New Revision: 40647
> >
> ...
> >   grass/trunk/include/spawn.h
> ...
> >   grass/trunk/lib/gis/spawn.c

> should I backport above changes?

Yes. They provide consistency between Unix and Windows.

Previously, the Unix version returned the raw exit status (exit code |
coredump flag | termination signal) while the Windows version returned
the exit code.

Now, both versions should return the exit code (the value returned
from main() or passed to exit()) in the event of normal termination.

FWIW, I wouldn't suggest back-porting r40647 or r40648 until they've
had a lot more testing.

In 7.0, system() and popen() (and the G_* versions) have been entirely
removed, except for $GRASS_NOTIFY (which is meant to be a shell
command) and GEM (which I wouldn't touch with a ten-foot pole).

[At least on Unix; there's probably still some _spawnl() calls and
maybe some system()s lurking within "#ifdef __MINGW32__" code.]

-- 
Glynn Clements <glynn at gclements.plus.com>


More information about the grass-dev mailing list