[GRASS-dev] Re: [GRASS-SVN] r40647 - in grass/trunk: display/d.title include lib/gis raster/r.out.mpeg raster/r.topmodel visualization/nviz/src visualization/xganim

[Glynn Clements]

Markus Neteler wrote:

> > Markus Neteler wrote:
> >
> >> On Mon, Jan 25, 2010 at 1:20 PM,  <svn_grass at osgeo.org> wrote:
> >> > Author: glynn
> >> > Date: 2010-01-25 07:20:13 -0500 (Mon, 25 Jan 2010)
> >> > New Revision: 40647
> >> >
> >> ...
> >> >   grass/trunk/include/spawn.h
> >> ...
> >> >   grass/trunk/lib/gis/spawn.c
> >
> >> should I backport above changes?
> >
> > Yes. They provide consistency between Unix and Windows.
> 
> Done so for lib/gis/spawn.c. Apparently include/spawn.h is
> not needed (I take your 6.5's backport as gold standard).

spawn.h needs <unistd.h> for the STD{IN,OUT,ERR}_FILENO constants.

This hasn't shown up before as modules often end up pulling in
<unistd.h> anyhow, but this is non-portable (e.g. including some other
header may end up including <unistd.h> on some platforms but not on
others).

-- 
Glynn Clements <glynn at gclements.plus.com>