[GRASS-dev] Re: [GRASS GIS] #1006: r.terraflow fails to stat() stream file on Windows

[GRASS GIS]

#1006: r.terraflow fails to stat() stream file on Windows
-----------------------------------+----------------------------------------
 Reporter:  marisn                 |       Owner:  grass-dev@…              
     Type:  defect                 |      Status:  new                      
 Priority:  critical               |   Milestone:  6.4.0                    
Component:  Raster                 |     Version:  svn-releasebranch64      
 Keywords:  wingrass, r.terraflow  |    Platform:  MSWindows Vista          
      Cpu:  x86-32                 |  
-----------------------------------+----------------------------------------

Comment(by hamish):

 Replying to [comment:37 mmetz]:
 > Well, then we have to change the way modules are presented in the menus.

 [aside] can we have a README.howto file in the gui/wxpython/xml/ dir?
 Every time I edit menudata.xml it seems to get overwritten some time later
 by an automated update which I don't see documented anywhere. It sort of
 kills my motivation to work on improving the menus anymore. tx.


 > > so it seems that it is prematurely reaching the end of the stream?
 >
 > I never thought I would agree to fix depression filling...

 :)

 > The mingw32 version of stream_len() does not work 100%,

 could you explain for us humble c++ students?

 > workaround in r42734 and r42735. Worksforme now on Windows. On
 > Linux, no difference in results.

 excellent!

 > Can I now put warning messages in r.terraflow that its
 > hydrological algorithms from the late 80ies and early 90ies do
 > not produce very accurate results (its emphasis is on the
 > computational complexity of the algorithms, rather than on
 > modeling realistic flow)?

 I'd rather you got together with Andrew and/or Laura and co-authored a
 journal article racing^W comparing the two with the current offerings from
 the other major proprietary GISs. :-) [seriously]

 http://www.cs.duke.edu/geo*/terraflow/speedup.html


 Are the core r.watershed algorithms by Ehlschlaeger any more modern? or
 have you now replaced and upgraded them to 'state of the art'? (whatever
 that means)


 > > > r.terraflow and iostream is written for Linux,

 well I knew a version for Arc existed, so thought it possible,
  http://wwwmath1.uni-muenster.de:8010/u/jan/TerraFlowExtension/


 > IMHO, the debug messages can be removed now, then the fix can
 > be backported to 6.4.1 ;-)

 I removed the noisiest one, will do the rest after testing tomorrow's
 autobuild. (and of course merge with trunk too)

 If it doesn't change results on UNIX it may as well go into 6.4.0. It
 doesn't matter how risky it is on Windows as it can't be worse than
 before. If you feel there's a risk for breakage on UNIX from this we could
 wait til 6.4.1 for the backport & disable building it in 6.4.0, but we
 should perhaps look over the menus in that case to make sure that the
 emphasis and descriptions are all up to date.


 cheers,
 Hamish

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/1006#comment:38>
GRASS GIS <http://grass.osgeo.org>