[GRASS-dev] Re: [GRASS GIS] #1059: wxGUI: No menu option for r.mapcalc

GRASS GIS trac at osgeo.org
Mon May 10 08:20:25 EDT 2010

#1059: wxGUI: No menu option for r.mapcalc
  Reporter:  vesnikos  |       Owner:  martinl        
      Type:  defect    |      Status:  reopened       
  Priority:  major     |   Milestone:  7.0.0          
 Component:  wxGUI     |     Version:  svn-trunk      
Resolution:            |    Keywords:  r.mapcalc wxGUI
  Platform:  Linux     |         Cpu:  x86-32         
Comment (by mmetz):

 Replying to [comment:14 martinl]:
 > Replying to [comment:13 mmetz]:
 > {{{
 > > Index: gui/wxpython/xml/menudata.xml
 > > ===================================================================
 > > --- gui/wxpython/xml/menudata.xml   (revision 42182)
 > > +++ gui/wxpython/xml/menudata.xml   (working copy)
 > > @@ -1010,7 +1010,9 @@
 > >     <menuitem>
 > >       <label>Map calculator</label>
 > >       <help>Map calculator for raster map algebra</help>
 > > +     <keywords>raster</keywords>
 > >       <handler>DispMapCalculator</handler>
 > > +     <command>r.mapcalc</command>
 > >     </menuitem>
 > >     <menu>
 > >       <label>Neighborhood analysis</label>
 > >
 > }}}
 > It shows [http://grass.osgeo.org/wiki/WxPython-
 based_GUI_for_GRASS#Map_Calculator wxGUI Map Calculator]. There is already
 item for {{{r.mapcalc}}} in the menu
 [source:grass/trunk/gui/wxpython/xml/menudata.xml at 42210#L1011]

 I was talking about r42182, before this flood of changes came in. My diff
 is against revision 42182, not revision 42210. In r42210, a lot of changes
 have been made to the GUI and the module, some of the changes have been
 changed again...

 My point is that probably much less changes were required to make
 r.mapcalc visible in the wxGUI command search, that the GUI should be
 fixed first, before modules get broken by a quick fix, that the two
 different interfaces for r.mapcalc are confusing, that more testing should
 be done on the local copy before a commit, and that the Map Calculator
 wxGUI interface is nice but unfinished work, no output, no help. I
 personally would recommend to go back to r42182 and start anew, looking
 for a solution that requires less modifications.

 Sorry for the ranting, but even though trunk is the development version, I
 would sometimes prefer some more testing before submitting changes, and a
 flood of commits for the same problem within one day clearly indicates
 that the first commits were not well thought through.

 Markus M

Ticket URL: <http://trac.osgeo.org/grass/ticket/1059#comment:16>
GRASS GIS <http://grass.osgeo.org>

More information about the grass-dev mailing list