[GRASS-dev] diglib test.c fails on 64bit win

[Glynn Clements]

Markus Metz wrote:

> >> To avoid confusion, on MINGW32 it would be better to not use
> >> _FILE_OFFSET_BITS=64 and don't set USE_LARGEFILES and HAVE_LARGEFILES
> >> even if LFS is requested? Unset/undefine somewhere in configure.in or
> >> a bit later in config.h.in USE_LARGEFILES and HAVE_LARGEFILES for
> >> MINGW32?
> >
> > How about:
> >
> >  if test $ac_cv_largefiles = yes; then
> >        USE_LARGEFILES=1
> > +       if test "$MINGW32" = yes ; then
> > +               AC_MSG_ERROR([*** --enable-largefile doesn't work on Windows])
> > +       fi
> >  fi
> 
> I dunnknonothin about AC_MSG_ERROR,

It prints the specified message then aborts the configure script.

> so I would do
> 
> >  if test $ac_cv_largefiles = yes; then
> >        USE_LARGEFILES=1
> > +       if test "$MINGW32" = yes ; then
> > +                USE_LARGEFILES=0
> > +       fi
> >  fi

This *silently* disables LFS. I would prefer to tell the user that LFS
isn't available.

> but that is your turf, you can judge what is portable. I guess, in the
> near future, MINGW64 will become more popular which is IMHO good and
> grass should consider this build environment.

I wouldn't assume that Win64 will be any different with regard to LFS. 
Apart from anything else, "long" is still only 32 bits on Win64.

-- 
Glynn Clements <glynn at gclements.plus.com>