[GRASS-dev] Re: [GRASS GIS] #1271: osgeo4w patch update

[GRASS GIS]

#1271: osgeo4w patch update
-------------------------+--------------------------------------------------
 Reporter:  jef          |       Owner:  grass-dev@…              
     Type:  enhancement  |      Status:  new                      
 Priority:  major        |   Milestone:  6.4.1                    
Component:  Default      |     Version:  svn-releasebranch64      
 Keywords:               |    Platform:  MSWindows Vista          
      Cpu:  Unspecified  |  
-------------------------+--------------------------------------------------

Comment(by hamish):

 mswindows/osgeo4w/package.sh:
 {{{
 -#!/c/OSGeo4W/apps/msys/bin/sh
 +#!/c/Programme/OSGeo4W/apps/msys/bin/sh
 }}}

 not portable dirname.

 +export OSGEO4W_ROOT_MSYS=/c/Programme/OSGeo4W

 local dirname, bashism with #!/bin/sh  (but fwiw works in dash)

 ---

 was all the change to use G_free(), db_free() needed or just "while you
 were there"? (needless clutter is to be avoided)

 ---

 why was it necessary to disable the GIS_H_VERSION check in
 lib/gis/gisinit.c?
 it is there for your protection.

 ---

 mostly I'm insterested to know if there are bugfixes in there we should
 know about, what is needed for a osgeo4w compile, what are cosmetic
 changes, and what in there is local preference/
 personal setup.


 thanks,
 Hamish

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/1271#comment:4>
GRASS GIS <http://grass.osgeo.org>