[GRASS-dev] Re: [GRASS-user] Re: g.extension and GRASS 6.4.1

[Hamish]

Markus wrote:
> > - g.extension failed upon wrong parameters in Platform.make
...
> I have implemented a solution for this, please retry from SVN.


Hi,

some minor coding comments on the implementation detail:

* is original hardcoded to '= /usr/local/' always true?
Platform.make.in has it variable:
prefix              = @prefix@
Use $BINDIR instead? it can change:
  Usage:  grass-$NAME_VER-install.sh \
              grass-$NAME_VER.tar.gz [dest_dir] [bin_dir]
...
# Check for third parameter:
if [ "$3" ] ; then
    BINDIR=$3
fi


* sed: instead of calling it 5 times you can just call it once:
sed -e 's+++' \
    -e 's+++' \
    -e 's+++' \
    -e 's+++' \
    -e 's+++' \
  < "$infile" > "$outfile"


* ${DESTDIR}/include/Make/Platform.make

${} does nothing to protect against spaces in path names. "Double
quote" instead. Use ${} when you need to protect the variable
name from alphanumeric or _ (etc) which would be confused as part
of the variable name. ${} gets evaluated at the expansion stage,
not the command evaluation stage.


Hamish