[GRASS-dev] Re: [GRASS GIS] #587: svn versions should better reflect svn rev

[GRASS GIS]

#587: svn versions should better reflect svn rev
--------------------------+-------------------------------------------------
  Reporter:  hamish       |       Owner:  grass-dev@…              
      Type:  enhancement  |      Status:  reopened                 
  Priority:  normal       |   Milestone:  6.4.2                    
 Component:  Default      |     Version:  svn-trunk                
Resolution:               |    Keywords:  g.version, configure     
  Platform:  All          |         Cpu:  All                      
--------------------------+-------------------------------------------------
Changes (by hamish):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Hi,

 g.version in 6.4.2rc3 reports:
 {{{
 GRASS 6.4.2RC3exported (2012)
 }}}

 because include/Make/Grass.make has:
 {{{
 GRASS_VERSION_SVN     = exported
 }}}

 (`svnversion`: "If invoked on a directory that is not a working copy, an
   exported directory say, the program will output 'exported'.")


 suggested patch:
 {{{
 Index: configure.in
 ===================================================================
 --- configure.in        (revision 50554)
 +++ configure.in        (working copy)
 @@ -128,6 +128,9 @@
  AC_PATH_PROG(SVN_VERSION, svnversion, no)
  if test "$SVN_VERSION" != "no" ; then
     GRASS_VERSION_SVN=`$SVN_VERSION -c | cut -f2 -d:`
 +   if test "$GRASS_VERSION_SVN" = "exported" ; then
 +      GRASS_VERSION_SVN=
 +   fi
  fi

  AC_SUBST(GRASS_VERSION_FILE)
 }}}

 todo: should `g.version -g` revision= report blank or just not be printed
 at all?


 Hamish

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/587#comment:63>
GRASS GIS <http://grass.osgeo.org>