[GRASS-dev] Re: [GRASS GIS] #1276: r.null in winGRASS does not work properly

[GRASS GIS]

#1276: r.null in winGRASS does not work properly
------------------------------+---------------------------------------------
 Reporter:  helena            |       Owner:  grass-dev@…              
     Type:  defect            |      Status:  new                      
 Priority:  critical          |   Milestone:  6.4.2                    
Component:  Raster            |     Version:  6.4.1 RCs                
 Keywords:  r.null, wingrass  |    Platform:  MSWindows 7              
      Cpu:  Unspecified       |  
------------------------------+---------------------------------------------

Comment(by glynn):

 Replying to [comment:10 hamish]:

 > From the timestamps (and r.info showing the correct range) I can confirm
 that cell_misc/$MAP/null and cell_misc/$MAP/range are updated when running
 r.null on Windows XP, but cell/$MAP's timestamp is not updated.

 AFAICT, the only way for G_close_cell() to not delete that file and not
 print a warning is if G__open_null_write() fails at line 207. But that
 should result in the null file not being updated (contrary to my previous
 comment, the null file isn't updated in-place; it's handled the same way
 as the cell/fcell file).

 Otherwise, it should attempt to rename the file, and any failure should
 generate a warning. There aren't any return statements in close_new()
 between renaming the null file and renaming the cell/fcell file, so I
 don't know how this situation can arise.

 > bug: close(fd) is called twice, (??)

 The first one (line 288) should be removed.

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/1276#comment:11>
GRASS GIS <http://grass.osgeo.org>