[GRASS-dev] [GRASS GIS] #778: i.rgb.his, i.his.rgb: propagate NULLs

[GRASS GIS]

#778: i.rgb.his, i.his.rgb: propagate NULLs
----------------------------------+-----------------------------------------
 Reporter:  hamish                |       Owner:  grass-dev@…              
     Type:  defect                |      Status:  new                      
 Priority:  major                 |   Milestone:  7.0.0                    
Component:  Raster                |     Version:  svn-trunk                
 Keywords:  i.rgb.his, i.his.rgb  |    Platform:  All                      
      Cpu:  Unspecified           |  
----------------------------------+-----------------------------------------

Comment(by glynn):

 Replying to [comment:1 cmbarton]:
 > Is this difficult to fix?

 Not really.

 In 7.0, nulls resulted in garbage. 7.0 doesn't have an equivalent of
 G_get_map_row(), but rgb2his/his2rgb don't explicitly check for nulls, so
 they will be treated as the literal value -2147483648. This should be
 fixed by r52207.

 In 6.x, change G_get_map_row() to G_get_c_raster_row() in main(), then
 manually back-port r52207.

 Also, we might want to do something about the hard-coded 0..255 range
 (r.composite uses the colour table to convert cell values to intensities),
 but that's a separate issue.

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/778#comment:2>
GRASS GIS <http://grass.osgeo.org>