[GRASS-dev] r.modis in GRASS 7 trunk

[Moritz Lennert]

On 31/10/12 10:47, Markus Metz wrote:
> On Wed, Oct 31, 2012 at 9:31 AM, Moritz Lennert
> <mlennert at club.worldonline.be>  wrote:
>> On 31/10/12 09:15, Markus Metz wrote:
>>>
>>> On Wed, Oct 31, 2012 at 5:58 AM, Yann Chemin<yann.chemin at gmail.com>
>>> wrote:
>>>>
>>>> On 31 October 2012 02:25, Helena Mitasova<hmitaso at ncsu.edu>   wrote:
>>>>>
>>
>>>>> Maybe PSC should have some mechanism to decide on which add-ons to move
>>>>> to
>>>>> trunk based on a defined set of criteria.
>>>>
>>>>
>>>>
>>>> +1
>>>
>>> I suggest that modules should not simply be moved from addons to
>>> trunk, but that a developer has a close look at a module including
>>> testing before moving it to trunk.
>>
>>
>> +1, but I see Martin's point about lack of dev power. So the trade-off has
>> to be between quality of code and value added of having a functionality in
>> trunk even if the code is not perfect.
>>
> True, but still, a little effort could be made. I did not mean
> exhaustive testing of the functionality, rather basic stuff like code
> formatting, checking for and removing any justified compiler warnings,
> for raster modules checking NULL handling and CELL/FCELL/DCELL
> handling, for vector modules checking feature type, category, and
> layer handling.

We should probably put all this into a quality check list for 
integration of modules into trunk. Maybe parts of those checks could 
even be automated ?

Moritz