[GRASS-dev] [GRASS GIS] #2084: Combine r.water.outlet easting=, northing= into coordinates= (G_OPT_M_COORDS) for mouse interactivity in g.gui.

[GRASS GIS]

#2084: Combine r.water.outlet easting=, northing= into coordinates=
(G_OPT_M_COORDS) for mouse interactivity in g.gui.
-------------------------+--------------------------------------------------
 Reporter:  hcho         |       Owner:  martinl  
     Type:  enhancement  |      Status:  assigned 
 Priority:  major        |   Milestone:  7.0.0    
Component:  Raster       |     Version:  svn-trunk
 Keywords:               |    Platform:  All      
      Cpu:  All          |  
-------------------------+--------------------------------------------------

Comment(by martinl):

 Done in r57762. There are three open issues

 (1) example noted in the manual gives strange result

 {{{
 r.report basin_A30 u=c -n -h --q
 +-----------------------------------------------------------------------------+
 |                         Category Information                          |
 cell|
 |#|description
 |count|
 |-----------------------------------------------------------------------------|
 |1| . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . |
 6|
 |-----------------------------------------------------------------------------|
 |TOTAL                                                                  |
 6|
 +-----------------------------------------------------------------------------+
 }}}

 (2) not sure about right fix of remaining compilator warning

 {{{
 In file included from basin.h:3:0,
                  from main.c:31:
 main.c: In function ‘main’:
 ramseg.h:7:32: warning: suggest parentheses around ‘+’ inside ‘<<’
 [-Wparentheses]
     ((((r) >> RAMSEGBITS) * (s) + (((c) >> RAMSEGBITS)) << DOUBLEBITS) \
                                 ^
 main.c:120:17: note: in expansion of macro ‘SEG_INDEX’
       drain_ptrs[SEG_INDEX(pt_seg, row, col)] = cell_buf[col];
                  ^
 ramseg.h:7:32: warning: suggest parentheses around ‘+’ inside ‘<<’
 [-Wparentheses]
     ((((r) >> RAMSEGBITS) * (s) + (((c) >> RAMSEGBITS)) << DOUBLEBITS) \
                                 ^
 main.c:135:26: note: in expansion of macro ‘SEG_INDEX’
       cell_buf[col] = bas[SEG_INDEX(ba_seg, row, col)];
 }}}

 (3) `MIN` macro could be probably used from libgis

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/2084#comment:3>
GRASS GIS <http://grass.osgeo.org>