[GRASS-dev] [GRASS GIS] #2503: wxdigit: wrong undo & redo

[GRASS GIS]

#2503: wxdigit: wrong undo & redo
--------------------------+-------------------------------------------------
  Reporter:  mlennert     |       Owner:  grass-dev@…              
      Type:  defect       |      Status:  closed                   
  Priority:  normal       |   Milestone:  7.0.0                    
 Component:  wxGUI        |     Version:  svn-trunk                
Resolution:  fixed        |    Keywords:  digitizer                
  Platform:  Unspecified  |         Cpu:  Unspecified              
--------------------------+-------------------------------------------------

Comment(by mlennert):

 Replying to [comment:12 mmetz]:
 > Replying to [comment:11 mmetz]:
 > > Replying to [comment:10 mlennert]:
 > > > Replying to [comment:9 mmetz]:
 > > > > Replying to [comment:8 mlennert]:
 > > > > > Replying to [comment:7 mmetz]:
 > > > > > > The list of updated lines as returned by the vector lib was
 incomplete. Fixed in r63349,50 (trunk, relbr70), please test.
 > > > > >
 > > > > > Still not quite:
 [http://tomahawk.ulb.ac.be/moritz/wxdigit_undo_redo4.ogv].
 > > > > >
 > > > > > If you need more explanation, I can write some, but right now I
 have to go.
 > > > >
 > > > > Got it. This bug (yet another one) should be fixed in r63364,5
 (trunk only).
 > > >
 > > > Wow, great detective work there ! As of now I haven't been able to
 find any other bugs linked to undo/redo. This fix should be backported to
 grass7release and then I think we can close this bug for now.
 > >
 > > I do not fully understand 1) why the fix is needed, 2) why the fix is
 working.
 >
 > The fix is working because V2_rewrite_line_nat() does not work as
 expected, it does not rewrite, it always deletes the line and writes out a
 new line (COW). All fixes related to this ticket have been backported to
 relbr70 in r63397,8 after testing.

 You just signficantly improved the use of the digitizer, thanks a lot !

 Just one question concerning r63398: shouldn't the code just be deleted
 instead of using 'if 0' ?

 Moritz

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/2503#comment:13>
GRASS GIS <http://grass.osgeo.org>