[GRASS-dev] [GRASS-SVN] r63505 - grass/trunk/gui/wxpython/vdigit

Vaclav Petras wenzeslaus at gmail.com
Fri Dec 12 08:10:35 PST 2014


On Fri, Dec 12, 2014 at 10:01 AM, <svn_grass at osgeo.org> wrote:

> wxGUI: don't use tabs in the code (introduced in r63341)


For convenience, there is a PEP8 configuration file with settings which
will not give you too much errors for GRASS (default/standard PEP8 setting
would give you an overwhelming amount of errors for gui/wxpython). You can
use it in the following was before you commit. Tabs would be reported as
error 101 (E101 indentation contains mixed spaces and tabs). In tools
directory, there is also a file for pylint with an example of usage.

$ pep8 --config=tools/pep8config.txt gui/wxpython/vdigit/
gui/wxpython/vdigit/dialogs.py:195:68: E262 inline comment should start
with '# '
gui/wxpython/vdigit/dialogs.py:196:57: E262 inline comment should start
with '# '
gui/wxpython/vdigit/dialogs.py:595:92: E703 statement ends with a semicolon
gui/wxpython/vdigit/dialogs.py:605:57: E703 statement ends with a semicolon
gui/wxpython/vdigit/main.py:25:5: E301 expected 1 blank line, found 0
gui/wxpython/vdigit/mapwindow.py:99:62: E226 missing whitespace around
arithmetic operator
gui/wxpython/vdigit/mapwindow.py:1102:68: E226 missing whitespace around
arithmetic operator
gui/wxpython/vdigit/toolbars.py:93:54: E701 multiple statements on one line
(colon)
gui/wxpython/vdigit/toolbars.py:94:54: E701 multiple statements on one line
(colon)
gui/wxpython/vdigit/toolbars.py:95:50: E701 multiple statements on one line
(colon)
gui/wxpython/vdigit/toolbars.py:1066:1: W391 blank line at end of file
gui/wxpython/vdigit/wxdigit.py:374:1: E101 indentation contains mixed
spaces and tabs
gui/wxpython/vdigit/wxdigit.py:375:1: E101 indentation contains mixed
spaces and tabs
gui/wxpython/vdigit/wxdigit.py:376:1: E101 indentation contains mixed
spaces and tabs
gui/wxpython/vdigit/wxdigit.py:377:1: E101 indentation contains mixed
spaces and tabs
gui/wxpython/vdigit/wxdigit.py:408:1: E101 indentation contains mixed
spaces and tabs
gui/wxpython/vdigit/wxdigit.py:611:78: E703 statement ends with a semicolon
gui/wxpython/vdigit/wxdigit.py:669:66: E703 statement ends with a semicolon
gui/wxpython/vdigit/wxdigit.py:678:44: E703 statement ends with a semicolon
gui/wxpython/vdigit/wxdigit.py:683:37: E703 statement ends with a semicolon
gui/wxpython/vdigit/wxdigit.py:742:20: W601 .has_key() is deprecated, use
'in'
gui/wxpython/vdigit/wxdigit.py:778:24: W601 .has_key() is deprecated, use
'in'
gui/wxpython/vdigit/wxdigit.py:1202:42: E703 statement ends with a semicolon
gui/wxpython/vdigit/wxdigit.py:1707:20: E711 comparison to None should be
'if cond is None:'
gui/wxpython/vdigit/wxdigit.py:1785:1: E101 indentation contains mixed
spaces and tabs
gui/wxpython/vdigit/wxdigit.py:1849:30: E226 missing whitespace around
arithmetic operator
gui/wxpython/vdigit/wxdigit.py:2040:1: W391 blank line at end of file
gui/wxpython/vdigit/wxdisplay.py:309:54: E226 missing whitespace around
arithmetic operator
gui/wxpython/vdigit/wxdisplay.py:309:73: E226 missing whitespace around
arithmetic operator
gui/wxpython/vdigit/wxdisplay.py:611:59: E226 missing whitespace around
arithmetic operator
gui/wxpython/vdigit/wxdisplay.py:1122:1: W391 blank line at end of file
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20141212/83cdb659/attachment-0001.html>


More information about the grass-dev mailing list