[GRASS-dev] [GRASS GIS] #2017: osgf compilation error (fixed?) (was: osgf compilation error)

[GRASS GIS]

#2017: osgf compilation error (fixed?)
-----------------------------------+----------------------------------------
 Reporter:  martinl                |       Owner:  grass-dev@…              
     Type:  defect                 |      Status:  new                      
 Priority:  blocker                |   Milestone:  7.0.0                    
Component:  Compiling              |     Version:  svn-trunk                
 Keywords:  libc, osgf, libavutil  |    Platform:  Linux                    
      Cpu:  x86-64                 |  
-----------------------------------+----------------------------------------

Comment(by edleaver):

 My I tactfully disagree? If one needs libffmpeg functions, by all means
 use them. Just lets not get carried away with compiler include directives.
 I've reproduced the particular problem as originally reported by martini
 on Fedora fc19 and fc20, where it is readily fixed:

 1. remove /usr/include/libavutil/ from --with-ffmpeg-includes paths

 2. lib/ogsf/gsd_img_mpeg.c line 33 should read
       #include <libavutil/mathematics.h>
    rather than
       #include <mathematics.h>

 That should be all that is necessary, for now. As a general point,
 however, one
 might opine that *all* libffmpeg #includes should be written relative to
 the first
 --with-ffmpeg-includes="/usr/include"
 directory, or on Fedora
 --with-ffmpeg-includes="/usr/include/ffmpeg"
 as shown above, though as a practical matter the "configure" script fails
 if it
 can't find at least some of the ffmpeg subdirectories and I wouldn't
 insist we fix such a thing that isn't otherwise broken.

 Think of the "top-level only" paradigm as being a method for maintaining
 separate
 namespaces for different development libraries. If in our Makefiles we
 "-I<everything under the sun>", then <everything under the sun> must have
 a unique file name, rather than just a unique relative path. Given enough
 libraries with
 enough separate headers, sooner or later we're going to have name
 collisions. We
 happened to hit one with libffmpeg. But if such is our philosophy, if not
 here it was going to happen another time, somewhere else.

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/2017#comment:13>
GRASS GIS <http://grass.osgeo.org>