[GRASS-dev] [GRASS GIS] #2341: GRASS 7.0.0. r.viewshed issue

[GRASS GIS]

#2341: GRASS 7.0.0. r.viewshed issue
-------------------------+--------------------------------------------------
 Reporter:  AJWatson     |       Owner:  grass-dev@…              
     Type:  enhancement  |      Status:  new                      
 Priority:  normal       |   Milestone:  7.0.0                    
Component:  Default      |     Version:  unspecified              
 Keywords:  r.viewshed   |    Platform:  MSWindows 8              
      Cpu:  Unspecified  |  
-------------------------+--------------------------------------------------

Comment(by neteler):

 Replying to [comment:2 AJWatson]:
 ...
 > r.viewshed --overwrite input=MasterRaster at CotswoldSevern
 output=MasterRaster coordinates=210320.28754,221864.696486
 > ERROR: Grid dimension too big for current precision

 Ok, now I found the issue (BTW: in SVN I have improved the error message):

 {{{
 cd raster/r.viewshed/

 grep maxDimension *.h
 grid.h:static const dimensionType maxDimension = USHRT_MAX - 1;

 grep USHRT_MAX /usr/include/limits.h
 #  define USHRT_MAX     65535
 }}}

 At least on my Linux system 65535 rows/cols seem to be the hardcoded
 maximum.

 I see this comment in grid.h:

 {{{
 /* this should accomodate grid sizes up to 2^16-1=65,535
    If this is not enough, change type and recompile */
 }}}

 So, it might be possible to allow for more (not sure if increasing
 maxDimension is sufficient and portable).

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/2341#comment:3>
GRASS GIS <http://grass.osgeo.org>