[GRASS-dev] G7: how to get rid of multiple listing of identical map names?

Huidae Cho grass4u at gmail.com
Mon Jun 23 00:14:59 PDT 2014


The exact same issue was discussed years ago (
http://osgeo-org.1560.x6.nabble.com/gis-m-crashes-on-zoom-to-map-existing-in-more-than-one-mapset-td4021119.html),
but was never fixed. I think this warning is more of a reminder, so
requiring --verbose to see this message doesn't seem to make much sense
although personally I hate to see the warning in module outputs because I
know what I'm doing. Especially, in r.info the message breaks the output
format.

Anyway, if we want to keep the message, I think it's reasonable to change
it to G_verbose_message even if then it cannot serve as a reminder.

On Sun, Jun 22, 2014 at 10:06 AM, Vaclav Petras <wenzeslaus at gmail.com>
wrote:

> Verbose message per map sounds good.
> On Jun 22, 2014 8:36 AM, "Huidae Cho" <grass4u at gmail.com> wrote:
>
>>  We have the same "new" issue in 6.4. I would just remove those warnings.
>>
>> It looks like those warning messages are somehow related to r22844 by
>> Glynn. The messages may be useful, but printing one warning per element for
>> the same map is too much and the user doesn't need to know what element is
>> being accessed. If we definitely want to show these similar messages, they
>> should be per map, not per element per map to avoid too much and annoying
>> verbosity.
>>
>> But still, IMHO, I don't see them *that* useful because the find_file
>> returns the first file found in the search path based on a known and
>> defined rule, which the user should already be familiar with. It's not that
>> something unexpected is happening. Why not changing them to
>> G_verbose_message or even G_debug?
>>
>>
>> On Sun, Jun 22, 2014 at 3:25 AM, Markus Neteler <neteler at osgeo.org>
>> wrote:
>>
>>> On Sun, Jun 22, 2014 at 5:16 AM, Huidae Cho <grass4u at gmail.com> wrote:
>>> > Hi Markus,
>>> >
>>> > That was r60261. It just suppresses the warnings.
>>>
>>> I see, so G_find_raster2() calls G_find_file2() calls find_file() in
>>> lib/gis/find_file.c
>>>
>>> > IMHO, those found in
>>> > multiple mapsets warnings are very noisy and unnecessary.
>>>
>>> Yes, definitely. And it is a "new" issue in GRASS 7, same use cases
>>> behave properly in GRASS 6.
>>>
>>> > Sometimes it
>>> > prints exactly the same messages multiple times and sometimes breaks
>>> > outputs. I think it's better to not print the warnings by default and
>>> print
>>> > them based on an argument or something, if we really need them.
>>>
>>> Should r60261 better be fixed in
>>> lib/gis/find_file.c
>>>
>>> ?
>>>
>>> Best
>>> Markus
>>>
>>
>>
>> _______________________________________________
>> grass-dev mailing list
>> grass-dev at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/grass-dev
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20140623/32934b22/attachment-0001.html>


More information about the grass-dev mailing list