[GRASS-dev] [GRASS GIS] #2083: Add 3D raster (volume) support to d.legend

GRASS GIS trac at osgeo.org
Mon May 5 03:08:34 PDT 2014


#2083: Add 3D raster (volume) support to d.legend
--------------------------------+-------------------------------------------
 Reporter:  wenzeslaus          |       Owner:  grass-dev@…              
     Type:  enhancement         |      Status:  new                      
 Priority:  normal              |   Milestone:  7.0.0                    
Component:  Display             |     Version:  svn-trunk                
 Keywords:  d.legend, raster3d  |    Platform:  All                      
      Cpu:  All                 |  
--------------------------------+-------------------------------------------

Comment(by hamish):

 ok, done in trunk, try >= r60104.

 I reworked most of the C code in the patch, but the python stuff was
 applied verbatim.


 some minor feedback/notes:

  * changed enum defines to be less like official ones in include/*.h. Also
 moved them into local_proto.h.

  * to help code readability used TRUE and FALSE for boolean ints. (defined
 in gis.h)

  * no need to use {curly} brackets if the statement which follows is a
 short one liner.

  * if $(RASTER3DLIB) is added to the Makefile, $(RASTER3DDEP) needs to be
 added too.

  * still need to figure out the trick to launch the GUI when no options
 are required but some option is required without asking the user to type '
 --ui'.

  * I added a new -c flag to `r3.stats` so that the new d.legend '-d'
 histogram distribution flag will work for raster3d maps too.


 please test.

 Hamish

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/2083#comment:8>
GRASS GIS <http://grass.osgeo.org>



More information about the grass-dev mailing list