[GRASS-dev] Debugging QGIS with GRASS provider on Windows

Radim Blazek radim.blazek at gmail.com
Mon Jun 22 00:22:09 PDT 2015


On Sun, Jun 21, 2015 at 4:42 AM, Vaclav Petras <wenzeslaus at gmail.com> wrote:
>
> On Sat, Jun 20, 2015 at 10:32 PM, Glynn Clements <glynn at gclements.plus.com>
> wrote:
>>
>> This specific issue may just need changing __MINGW32__ to WIN32 (or
>> _WIN32 or _WINNT, all of which are defined by MinGW) so that MSVC gets
>> the same treatment.
>
> This might be a good idea in general. I think I saw some __MINGW32__ #ifs
> which (according to the code) meant to check for MS Windows system not MinGW
> compiler.

Do you think that __MINGW32__ may be changed to WIN32 globally without
inspecting each case? There are probably really __MINGW32__ specific
places. Inspecting each  __MINGW32__ individually seems to be the
largest amount of work doing port to MSVC.

Radim


More information about the grass-dev mailing list