[GRASS-dev] [GRASS GIS] #2941: r.sun: wrong sign in equation of time

[GRASS GIS]

#2941: r.sun: wrong sign in equation of time
--------------------------+-------------------------
  Reporter:  tomhuld      |      Owner:  grass-dev@…
      Type:  defect       |     Status:  new
  Priority:  normal       |  Milestone:  7.0.4
 Component:  Raster       |    Version:  unspecified
Resolution:               |   Keywords:  r.sun
       CPU:  Unspecified  |   Platform:  Unspecified
--------------------------+-------------------------
Changes (by neteler):

 * keywords:   => r.sun
 * component:  Default => Raster


Comment:

 Replying to [ticket:2941 tomhuld]:
 > Bug report ticket #2876 by fabriziosossan reported a problem with the
 equation of time in r.sun, whereby the calculation of the solar time from
 the clock (civil) time is wrong. The problem was fixed with a patch for
 GRASS 6,

 So far the proposed patch has not been applied. Should it be? From the
 discussion in ticket #2876 it is not clear to me.

 > but as far as I know there the fix was not applied to GRASS 7.
 >
 > I would like to suggest the following patch for r.sun/main.c. Since this
 is my first patch for GRASS, apologies if I'm doing it worng.

 Ideally please submit the diff as an attachment by (in this case) running

 {{{
 # from main source code directory
 svn diff raster/r.sun/ > r_sun.diff
 }}}

 (For now, I have reformatted your comment here by protecting it with curly
 braces.)

 Should your change be submitted in addition to the patch proposed in
 ticket #2876 or exclusively your change?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2941#comment:2>
GRASS GIS <https://grass.osgeo.org>