[GRASS-dev] [GRASS GIS] #3000: i.gensig overwrites signature file without warning

GRASS GIS trac at osgeo.org
Sun May 15 05:50:44 PDT 2016

#3000: i.gensig overwrites signature file without warning
  Reporter:  marisn       |      Owner:  grass-dev@…
      Type:  defect       |     Status:  closed
  Priority:  normal       |  Milestone:  7.2.0
 Component:  Imagery      |    Version:  svn-trunk
Resolution:  fixed        |   Keywords:  i.gensig
       CPU:  Unspecified  |   Platform:  Unspecified

Comment (by marisn):

 Sorry, that change is wrong as it will check for file presence only if
 OVERWRITE is set and fail to do so if it is unset (usual case). I reverted
 it in r68432

 I implemented a new function to find signature files in r68433 to not
 change I_find_subgroup_file function within 7.x lifetime. Good question if
 all hardcoded directory separators in lib/imagery should not be replaced
 with HOST_DIRSEP as it is done in r68433 to match how G_file_name works.
 Needs testing on Windows.

 As of r68434 all (I hope) signatures generating modules perform check to
 not overwrite signature file.

Ticket URL: <https://trac.osgeo.org/grass/ticket/3000#comment:4>
GRASS GIS <https://grass.osgeo.org>

More information about the grass-dev mailing list