[GRASS-dev] [GRASS GIS] #3343: v.label.sa broken and duplicated in trunk and addons

[GRASS GIS]

#3343: v.label.sa broken and duplicated in trunk and addons
-------------------------------------------------+-------------------------
 Reporter:  wenzeslaus                           |      Owner:  grass-dev@…
     Type:  defect                               |     Status:  new
 Priority:  trivial                              |  Milestone:  7.4.0
Component:  Addons                               |    Version:  svn-trunk
 Keywords:  v.label.sa, FTLIB, FreeType,         |        CPU:  Unspecified
  compilation                                    |
 Platform:  Unspecified                          |
-------------------------------------------------+-------------------------
 v.label.sa code is both in trunk and in addons repository. The versions
 are the same except for few characters. The compilation is disabled in
 trunk and it is broken in addons with:

 {{{
 labels.c: In function ‘labels_init’:
 labels.c:88:5: error: implicit declaration of function
 ‘find_font_from_freetypecap’ [-Werror=implicit-function-declaration]
 labels.c:88:14: warning: assignment makes pointer from integer without a
 cast [enabled by default]
 labels.c:100:5: error: implicit declaration of function ‘free_fontcap’
 [-Werror=implicit-function-declaration]
 }}}

 In G6 the compilation is conditional:

 {{{
 REQUIRESFT = v.label.sa

 ifneq ($(strip $(FTLIB)),)
     SUBDIRS += $(REQUIRESFT)
 endif
 }}}

 and the `v.label.sa` code in G6 contains the missing function
 `find_font_from_freetypecap()`.

 The `free_fontcap` function is in `lib/driver/driverlib.h` in G7.

 I suggest to remove the trunk version. Fixing the code would be nice of
 course.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3343>
GRASS GIS <https://grass.osgeo.org>