[GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

[Rashad Kanavath]

On Mon, Jan 23, 2017 at 9:22 AM, Moritz Lennert <
mlennert at club.worldonline.be> wrote:

> Hi Rashad,
>
> On 22/01/17 11:00, Rashad Kanavath wrote:
>
>> I fixed all the points from last mail.
>>
>
> Wonderful !
>
> It seems that you missed one point (see in the ticket #3142/#3247).
>
> Thank you so much for this great job !
>

Thanks. Sorry that I missed it. I will push a fix for both and update the
tracker too.



> Moritz
>
>
>
>
>> On Fri, Jan 6, 2017 at 9:28 AM, Markus Metz
>> <markus.metz.giswork at gmail.com <mailto:markus.metz.giswork at gmail.com>>
>> wrote:
>>
>>
>>
>>     On Tue, Dec 27, 2016 at 9:05 PM, Rashad Kanavath
>>     <mohammedrashadkm at gmail.com <mailto:mohammedrashadkm at gmail.com>>
>> wrote:
>>
>>
>>
>>         I had pushed a updated version of code:
>>
>>         Done:
>>         1. input is a imagery group from i.group (handles all raster in
>>         the group)
>>         2. removed rgb2lab conversion
>>         3. implementation of id output map
>>         4. replaced  fmin with MIN and MAX macro
>>         5. compactness is a new option to module? (default is 20 from
>> paper)
>>
>>     Wonderful, thanks!
>>
>>
>>         TODO:
>>         1. add option for SLICO
>>         2. use segment library to avoid memory limitation when reading
>>         raster data
>>
>>         Hope this works now. Let me know If I missed something else.
>>
>>     Code clean-up:
>>     - please use tools/grass_indent.sh
>>     - move variable declarations to the beginning of a code block
>>     - convert C++ style comments to C style comments
>>     - line 155
>>       int sz = nrows * ncols;
>>
>>     can cause integer overflow. Use off_t (large raster maps can only be
>>     handled with LFS, i.e. off_t being a 64bit integer).
>>
>>     - fix L157: must be
>>       int **pdata;
>>
>>       pdata = G_malloc(sizeof(int) * group_ref.nfiles);
>>
>>     - Lines 317,318 are correct, line 320 is wrong
>>
>>
>>         And...
>>
>>         Happy New Year to all :-)
>>
>>     Happy new year to you too!
>>
>>     Markus M
>>
>>
>>
>>         On Thu, Dec 22, 2016 at 10:12 AM, Markus Neteler
>>         <neteler at osgeo.org <mailto:neteler at osgeo.org>> wrote:
>>
>>             On Thu, Dec 22, 2016 at 12:01 AM, Markus Metz
>>             <markus.metz.giswork at gmail.com
>>             <mailto:markus.metz.giswork at gmail.com>> wrote:
>>             ...
>>             > Adding
>>             >
>>             > #undef MIN
>>             > #define MIN(a,b) ((a) < (b) ? (a) : (b))
>>             >
>>             > as in other GRASS modules is a nice solution to keep things
>> simple and
>>             > portable.
>>
>>             ... how about a adding this and similar definitions to gis.h?
>>
>>             markusN
>>             _______________________________________________
>>             grass-dev mailing list
>>             grass-dev at lists.osgeo.org <mailto:grass-dev at lists.osgeo.org>
>>             http://lists.osgeo.org/mailman/listinfo/grass-dev
>>             <http://lists.osgeo.org/mailman/listinfo/grass-dev>
>>
>>
>>
>>
>>         --
>>         Regards,
>>            Rashad
>>
>>
>>
>>
>>
>> --
>> Regards,
>>    Rashad
>>
>
>


-- 
Regards,
   Rashad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20170123/4af1bd06/attachment.html>