[GRASS-dev] [GRASS GIS] #3269: r.roughness.vector: bug in rescale formula

[GRASS GIS]

#3269: r.roughness.vector: bug in rescale formula
--------------------------+--------------------------------------
  Reporter:  sbl          |      Owner:  grass-dev@…
      Type:  defect       |     Status:  new
  Priority:  normal       |  Milestone:  7.2.1
 Component:  Default      |    Version:  unspecified
Resolution:               |   Keywords:  AddOn,r.roughness.vector
       CPU:  Unspecified  |   Platform:  All
--------------------------+--------------------------------------

Comment (by hellik):

 Replying to [comment:2 sbl]:
 > Yes, same issue there.
 > For what I can see, line 265 in https://trac.osgeo.org/grass/browser
 /grass-addons/grass6/raster/r.roughness/r.roughness.window.vector.sh
 > should be changed equally like this:
 >
 > {{{
 > - r.mapcalc $FISHER = "($window * $window - $STRENGTH) / ($window *
 $window - 1)"
 > + r.mapcalc $FISHER = "($window * $window - $STRENGTH) / ($window *
 $window)"
 > }}}
 > Result should be scaled from 0 to 1. Thus formula should be:
 >
 > {{{
 > V' = (max(V[i-j]) - V) / max(V[i-j]
 > }}}

 Could you ping Carlos, the author of both addons, regarding this issue?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3269#comment:3>
GRASS GIS <https://grass.osgeo.org>